Bruce Rothermal wrote:
> Made changes from review
>
> http://cr.opensolaris.org/~bruce_r/powerman-2.3/
usr/src/cmd/powerman/Makefile.sfw
- I don't think these lines are doing anything
32 PDIR=$(SRC)/cmd/powerman
61 MANSCRIPT=$(PDIR)/sunman-stability \
- I would change this:
65 $(SH) ./install-sfw
- to:
65 PKGDIR=$(VER) $(SHELL) ./install-sfw
usr/src/cmd/powerman/install-sfw
- something like this should work better. You can
remove the mv lines
38 _install M ${PKGDIR}/cmd/powerman/powerman.1 ${MAN1}/powerman.1 444
The CDDL headers still need work.
usr/src/pkgdefs/SUNWpowermanr/copyright
usr/src/pkgdefs/SUNWpowermanu/copyright
- these copyright statements have nothing to do
with the powerman code:
11 Copyright (C) 2002-2006 Stephen Kennedy <stevek at gnome.org>
12 Copyright (C) 2003-2007 Free Software Foundation, Inc.
13 Copyright (C) 2003-2005 Miloslav Trmac <mitr at volny.cz>
14 Copyright (C) 2004-2005 Adam Weinberger and the GNOME Foundation.
15 Copyright (C) 2005 Daniel Thompson <daniel at redfelineninja.org.uk>
16 Copyright (C) 2005 Ali Afshar <aafshar at gmail.com>
17 Copyright (C) 2005-2006 Gnome i18n Project for Vietnamese.
18 Copyright (C) 2006 Ilkka Tuohela <hile at iki.fi>
- you need to add the correct copyright statements from
the powerman source code.
> Roland Mainz wrote:
> > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw*
> > and add a $ set -o errexit # at the beginning and
> > replace ". ${SRC}/tools/install.subr" with
> > "source ${SRC}/tools/install.subr" (the idea is to
> > catch failures in the script and abort it at that point,
> > right now the script will just continue)
Changed to bash
Please do what is being asked above (ie. don't change to bash).
Cheers,
Jim
