Petr Slechta wrote:
> Hello Jim,
> 
> I don't know which file do you address by the following:
> 
>> Can pkgs include anything they need even if it duplicates
>> other jar files? 
> 
> If you mean findbugs-ant-1.3.5.jar file, then this is not Ant 
> implementation, it is just findbugs' extension to the Ant, i.e. command 
> that extends standard Ant to be able to run findbugs from ant scripts.

Sorry. I meant ant.jar.

I'm concerned about these jar files:

163 f none usr/share/lib/java/findbugs/asm-analysis-3.1.jar
164 f none usr/share/lib/java/findbugs/asm-xml-3.1.jar
165 f none usr/share/lib/java/findbugs/asm-util-3.1.jar
167 f none usr/share/lib/java/findbugs/jsr305.jar
169 f none usr/share/lib/java/findbugs/asm-tree-3.1.jar
170 f none usr/share/lib/java/findbugs/dom4j-1.6.1.jar
172 f none usr/share/lib/java/findbugs/ant.jar
173 f none usr/share/lib/java/findbugs/asm-3.1.jar
174 f none usr/share/lib/java/findbugs/jaxen-1.1.1.jar
175 f none usr/share/lib/java/findbugs/asm-commons-3.1.jar
176 f none usr/share/lib/java/findbugs/bcel.jar

Is ant.jar functionally the same as what is already installed here?

/usr/share/lib/ant/ant.jar

Can you do a symlink for findbugs to the current ant.jar location?

Do you build any of the above or do you just copy them?

I'm not concerned about these jar files, assuming you
build them:

166 f none usr/share/lib/java/findbugs/findbugs-ant-1.3.5.jar
168 f none usr/share/lib/java/findbugs/findbugs-1.3.5.jar
171 f none usr/share/lib/java/findbugs/annotations.jar

Just to clarify, I'm concerned about the following:

1. Does findbugs duplicate ant.jar that already exist?

2. Can jar files be ported to SFW without building from src?

3. Should the following jar files be located at /usr/share/lib/java
since they are more general purpose then findbugs?

asm-*.jar       http://asm.objectweb.org/
dom4j*.jar      http://www.dom4j.org/
jaxen*.jar      http://jaxen.codehaus.org/
bcel.jar        http://jakarta.apache.org/bcel/

4. Should the above four projects be ported separately?

How we approach findbugs jar files can define how we approach jar
files in the future.

Cheers,
Jim


> 
> 
> 
> Jim Walker wrote:
>> Petr Slechta wrote:
>>> Hello!
>>>
>>> Comments from Paul Cunningham incorporated, second version of webrev 
>>> is available at http://cr.opensolaris.org/~pslechta/findbugs2/
>>>
>>
>> Brian,
>>
>> Can you take a look at the package contents:
>>
>> http://cr.opensolaris.org/~pslechta/findbugs2/usr/src/pkgdefs/SUNWfindbugs/prototype_com.html
>>  
>>
>>
>> It doesn't seem to correspond to the LSARC/2008/642 interfaces:
>>
>> Is this internal file the most recent proposal file:
>> fosslist.txt
>>
>> I don't see any external interface summary:
>> http://www.opensolaris.org/os/community/arc/caselog/2008/642
>>
>> Norm,
>>
>> What's the current sfw c-team policy on jar files including jar
>> files like ant which are present elsewhere?
>>
>> Specifically:
>>
>> Can pkgs include anything they need even if it duplicates
>> other jar files?
>>
>> Do jar files need to be built from source code?
>>
>> Cheers,
>> Jim
> 


Reply via email to