Jim Walker wrote: > Petr Slechta wrote: >> Hello Jim, >> >> I don't know which file do you address by the following: >> >>> Can pkgs include anything they need even if it duplicates >>> other jar files? >> >> If you mean findbugs-ant-1.3.5.jar file, then this is not Ant >> implementation, it is just findbugs' extension to the Ant, i.e. >> command that extends standard Ant to be able to run findbugs from ant >> scripts. > > Sorry. I meant ant.jar. > > I'm concerned about these jar files: > > 163 f none usr/share/lib/java/findbugs/asm-analysis-3.1.jar > 164 f none usr/share/lib/java/findbugs/asm-xml-3.1.jar > 165 f none usr/share/lib/java/findbugs/asm-util-3.1.jar > 167 f none usr/share/lib/java/findbugs/jsr305.jar > 169 f none usr/share/lib/java/findbugs/asm-tree-3.1.jar > 170 f none usr/share/lib/java/findbugs/dom4j-1.6.1.jar > 172 f none usr/share/lib/java/findbugs/ant.jar > 173 f none usr/share/lib/java/findbugs/asm-3.1.jar > 174 f none usr/share/lib/java/findbugs/jaxen-1.1.1.jar > 175 f none usr/share/lib/java/findbugs/asm-commons-3.1.jar > 176 f none usr/share/lib/java/findbugs/bcel.jar > > Is ant.jar functionally the same as what is already installed here? ant.jar should not be part of the package. I will remove it from prototype. It was mistake. Thanks for catching it! (The ant.jar file is not used by findbugs.)
> > /usr/share/lib/ant/ant.jar > > Can you do a symlink for findbugs to the current ant.jar location? > > Do you build any of the above or do you just copy them? They are just copied from the distribution. I just follow the same build process as findbugs use. If you run findbugs compilation, they also just take all the libraries and do not compile them from sources... > > I'm not concerned about these jar files, assuming you > build them: > > 166 f none usr/share/lib/java/findbugs/findbugs-ant-1.3.5.jar > 168 f none usr/share/lib/java/findbugs/findbugs-1.3.5.jar > 171 f none usr/share/lib/java/findbugs/annotations.jar > > Just to clarify, I'm concerned about the following: > > 1. Does findbugs duplicate ant.jar that already exist? Sorry again, ant.jar will not be in the findbugs package. > > 2. Can jar files be ported to SFW without building from src? I don't know, this must be answered by some expert on SFW build process. But as I said, most of Java open-source projects just take the libraries and use them (and do not compile them from sources). This is also the way how findbugs' build is designed. > > 3. Should the following jar files be located at /usr/share/lib/java > since they are more general purpose then findbugs? > > asm-*.jar http://asm.objectweb.org/ > dom4j*.jar http://www.dom4j.org/ > jaxen*.jar http://jaxen.codehaus.org/ > bcel.jar http://jakarta.apache.org/bcel/ This was already discussed on LSARC review. Please see the archive http://sac.eng.sun.com/Archives/CaseLog/arc/LSARC/2008/642/mail and look for discussion around the following paragraph: " Is there case precedent that indicates that all libraries should be versioned when installed? What happens for consumers of various version of: dom4j.jar, jaxen.jar, jsr-305.jar, et al listed there - presumably those won't be symlinks? Given the amount of java applications and scaffolding that's in the project pipeline, are we heading towards java jar hell? " I believe it is better not to share all jar files, because of versioning problems... > > 4. Should the above four projects be ported separately? I hope not. If we do so, it would be extremely hard to port any Java application. Again, please see LSARC discussion. I was hoping that these questions are already solved by LSARC review... > > How we approach findbugs jar files can define how we approach jar > files in the future. I see. But please see how other Linux/Unix distributions do solve this problem... The package structure for findbugs is inspired by Mandriva Linux distribution. Please let me know how to continue... Is LSARC discussion regarding the package structure unclear? Should we reopen LSARC? Thanks, Petr > > Cheers, > Jim > > >> >> >> >> Jim Walker wrote: >>> Petr Slechta wrote: >>>> Hello! >>>> >>>> Comments from Paul Cunningham incorporated, second version of >>>> webrev is available at http://cr.opensolaris.org/~pslechta/findbugs2/ >>>> >>> >>> Brian, >>> >>> Can you take a look at the package contents: >>> >>> http://cr.opensolaris.org/~pslechta/findbugs2/usr/src/pkgdefs/SUNWfindbugs/prototype_com.html >>> >>> >>> >>> It doesn't seem to correspond to the LSARC/2008/642 interfaces: >>> >>> Is this internal file the most recent proposal file: >>> fosslist.txt >>> >>> I don't see any external interface summary: >>> http://www.opensolaris.org/os/community/arc/caselog/2008/642 >>> >>> Norm, >>> >>> What's the current sfw c-team policy on jar files including jar >>> files like ant which are present elsewhere? >>> >>> Specifically: >>> >>> Can pkgs include anything they need even if it duplicates >>> other jar files? >>> >>> Do jar files need to be built from source code? >>> >>> Cheers, >>> Jim >> >
