Petr, I few more comments ...
Paul Petr Slechta wrote: > > second version of webrev is > available at http://cr.opensolaris.org/~pslechta/findbugs2/ 1. usr/src/Targetdirs & usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile Change the Copyright year to 2009 2. usr/src/cmd/findbugs/install-sfw Do you need the 'mkdir's - aren't the dirs already created via Targetdirs (if not they should be) 3. usr/src/cmd/findbugs/Makefile.sfw Do you actually need the 'protofix' call, isn't everything already set correctly in install-sfw? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
