John Gu wrote:
> Would you please pay a visit at 
> http://cr.opensolaris.org/~john.gu/libsigsegv/ :-) 

Please make the CDDL and copyright headers in all files
be consistent with this:
http://cr.opensolaris.org/~uniopen/mrtg/usr/src/pkgdefs/SUNWmrtg/pkginfo.tmpl.html

usr/src/lib/libsigsegv/Makefile.sfw
- see if you can simplify the build process like is done here:
http://cr.opensolaris.org/~eddie/lua/usr/src/cmd/lua/Makefile.sfw.html

usr/src/lib/libsigsegv/sigsegv.3
- can you send out a text version of the man page for review?

usr/src/lib/libsigsegv/sigsegv_deinstall_handler.3
usr/src/lib/libsigsegv/sigsegv_dispatch.3
usr/src/lib/libsigsegv/sigsegv_init.3
usr/src/lib/libsigsegv/sigsegv_install_handler.3
usr/src/lib/libsigsegv/sigsegv_register.3
usr/src/lib/libsigsegv/sigsegv_unregister.3
usr/src/lib/libsigsegv/stackoverflow_deinstall_handler.3
usr/src/lib/libsigsegv/stackoverflow_install_handler.3
- how are these files used relative to generating
the man pages?
    1 .so man3/sigsegv_install_handler.3
...

usr/src/pkgdefs/SUNWlibsigsegv/copyright
- add a dotted line and copyright statements from the
source files like this:
http://cr.opensolaris.org/~jwalker/meld/usr/src/pkgdefs/SUNWmeld/copyright.html

usr/src/pkgdefs/SUNWlibsigsegv/prototype_com
- remove the following blank lines:
46
53

Cheers,
Jim

Reply via email to