David, Below are some more comments ...
Paul David.Fan at Sun.COM wrote: > Here's the webrev: > > http://cr.opensolaris.org/~dfan/gocr 1. I still think you should do these (see recent putbacks for examples) .... >> On 11/20/08 02:46, Paul Cunningham wrote: >>> 2. usr/src/cmd/gocr/Makefile.sfw >>> You could extract the VER= stuff from the METADATA, something >>> like ... >>> VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) >>> TARBALL =$(VER).tar.gz ... cut ... >>> 3. usr/src/cmd/gocr/install-sfw >>> You could pass in the PKGVERS= stuff as an environment >>> var from Makefile.sfw 2. usr/src/cmd/Makefile Your webrev is missing the change in here for this new pkg 3. usr/src/pkgdefs/Makefile The file looks as though it needs resyncing with the gate, otherwise it looks as though you a trying to delete stuff! 4. usr/src/pkgdefs/SUNWgocr/depend Do you still need SUNWgccruntime in here ? 5. Copyright year You might want to change the copyright year in all the new and changed files to 2009 now prior to putback -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
