David, This mainly looks good to me, just a few minor comments, see below ...
Paul David.Fan at Sun.COM wrote: > > We are porting GOCR, an open source character recognition program, to > OpenSolaris. Please take some time to review the webrev at: > > Webrev: > http://cr.opensolaris.org/~steven84/gocr/ > > GORC homepage: > http://jocr.sourceforge.net/links.html > === Start of Comments ==== 1. usr/src/cmd/gocr/METADATA You might want to add the missing field, see guidelines at ... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 2. usr/src/cmd/gocr/Makefile.sfw You could extract the VER= stuff from the METADATA, something like ... VER =$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) TARBALL =$(VER).tar.gz Could this have been built with the sun compiler rather than gcc ? 3. usr/src/cmd/gocr/install-sfw You could pass in the PKGVERS= stuff as an environment var from Makefile.sfw 4. usr/src/pkgdefs/SUNWgocr/prototype_com 45 # SUNWbonnieplus ??? === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
