Hi, Milan Jurik wrote:
> Hi, > > I have only one question (not reviewing the rest) - why do you need > update Targetdirs? > > SBLIMCIMClient build process is not able to create these subdirectories? There was a discussion on this issue in another mail thread initiated by Amanda and Mike has given his opinion. As per that, the directories that could be shared by other packages (top level dirs) are included in Targetdirs. The directories which are private to a package (Ex: the javadoc dirs created by sblim) are created by the install-sfw script. Hence I would like to keep the entries for /usr/share/lib/sblim and /usr/share/doc/sblim in Targetdirs and the remaining in install-sfw script. Paul Cunningham wrote: > === Start of Comments === > > 1. usr/src/lib/sblim/Makefile.sfw > & usr/src/lib/sblim/install-sfw > You might want to remove the version string "1.3.7" on the > comment lines, otherwise you are going to have to change > these files everytime you increment the pkg version > just to change this comment line. > Done > 2. usr/src/lib/sblim/Makefile.sfw > Think I would prefer to see this line ... > 39 unzip -q -o $(TARBALL) > in its own rule (instead of under 'all:') and then > the 'all:' rule depend on that rule. > > Done > 3. usr/src/lib/sblim/install-sfw > The directories created by 'mkdir -p' should probably > already be in the Targetdirs file. > As mentioned above, I have included common dirs in Targetdirs and the package specific ones in install-sfw > 4. usr/src/pkgdefs/SUNWSBLIMCIMClient/copyright > Do you really need all the multiple "(C) Copyright IBM Corp." > lines. Doesn't ... > 6 (C) Copyright IBM Corp. 2005, 2008 > cover them all? > > Not sure if "2005, 2008" represents range here but just specifies the years only (Guess "2005-2008" would indicate the range) Hence I have included all the copyright lines. > 5. SUNWSBLIMCIMClient package name > I find this name confusing - its hard to see where the > splits in it are unless you know ... > SUNW SBLIM CIM Client > Maybe you could think about changing it. > Changed the package name to SblimCimClient. I have updated the webrev with changes as per your comments. Please help review it again.( http://cr.opensolaris.org/~bkumarm/sblimcimclient/ ) Thanks Bharath > === End of Comments ===== >
