Hi Paul, Paul Cunningham wrote: > > > Bharath Kumar wrote: >> Paul Cunningham wrote: >>> Bharath Kumar wrote: >>> ... cut ... >>>> >>>> I have updated the webrev with changes as per your comments. Please >>>> help review it again.( >>>> http://cr.opensolaris.org/~bkumarm/sblimcimclient/ ) >>> >>> What's there looks good to me. >>> But your new webrev is missing .... >>> >>> usr/src/pkgdefs/SUNWSblimCimClient/Makefile >>> usr/src/pkgdefs/SUNWSblimCimClient/copyright >>> >> Missed them while doing wx ci. Updated the webrev with these files now. > > I personal still don't like all those "C) Copyright IBM Corp. ..." > lines in the SUNWSblimCimClient/copyright file - but if you are happy > then its okay with me. > >>> I can't remember if it had its own 'depend' file - if not have you >>> checked it doesn't have any other dependencies other than the defaults? >>> >> No it uses default depend file. > > but did you check there aren't any other dependencies required with > the dependency checker script? Yes, I have run the check-deps.pl script and it does not show any other dependencies.
Thanks Bharath > > Otherwise its good > > paul >
