Petr Sumbera wrote: > I have added missing patches. Webrev is updated. > > Btw. Do we have any reviewers? > > Petr >
These look fine to me, but I am noting the few minor differences from Brian's. The only one that tickles my neurons is Brian appears to have cleaned up the pkg dependencies. I didn't verify a single one of those so since this new webrev makes no change to that, the worst that happens is unnecessary dependencies continue forward. Maybe that is the gap caused by not going against a "real" workspace as you mentioned in your changechangelog? > Brian Gupta wrote: > >> On Mon, Jan 19, 2009 at 11:17 AM, Petr Sumbera <Petr.Sumbera at sun.com> >> wrote: >> >>> Hi Brian and Vim/GVim reviewers, >>> >>> I have prepared webrev based on real workspace inside Sun: >>> >>> http://cr.opensolaris.org/~xsumbe00/6795318-vim72/ >>> >>> Here are changes against original webrev: >>> - 2009 Copyright updated for modified files. >>> - small fixes in Vim Makefile.sfw (against very original implementation) >>> - GVim changes redone from scratch (your Webrev didn't reflect real GVIm >>> putback). But it was easy ;-) >>> >>> Brian, if you are ok with this, I will start sponsoring process. >>> >>> Thanks, >>> >>> Petr >>> >>> Brian Gupta wrote: >>> >>>> Webrevs: >>>> ----------- >>>> http://cr.opensolaris.org/~brandorr/vim72-webrev/ >>>> http://cr.opensolaris.org/~brandorr/gvim72-webrev/ >>>> >>>> Files that need to be "removed" from repo when integrated: >>>> >>>> ------------------------------------------------------------------------------- >>>> http://cr.opensolaris.org/~brandorr/vim72-files-to-remove.txt >>>> >>>> Notes: >>>> -------- >>>> - webrevs are taken against 106 >>>> - patches updated for 7.2 (Currently I am in the process of syncing up >>>> with upstream, as the patches are a few weeks old now.) >>>> - gvim doesnt have it's own source tarball, it copies it from the vim >>>> dir and builds it . This is how we did 7.1 as well. >>>> - webrevs generated against files as we, outside of sun, do not have >>>> access to mercurial/teamware >>>> >> Petr, >> >> I have a new webrev, that brings the patches up to patch level >> 7.2.084. Do you want me to upload it, or do you just want to go with >> patch level 7.2.077? >> >> Thanks, >> Brian >> >> > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
