Jan Hnatek wrote:
> Hi Paul,
>
> thanks for your comments.
Thats okay ...
> Paul Cunningham wrote:
>> [..]
>> 1. usr/src/pkgdefs/SUNWhunspell/depend
>> Move the Copyright lines to after the
>> "CDDL HEADER END" header
> Fixed.
>
>>
>> 2. usr/src/pkgdefs/SUNWhunspell/copyright
>> Was it intentional to have the strange characters on
>> these lines ? ....
>> 15 Copyright (C) 2002-2008 L??szl?? N??meth <nemeth at openoffice.org>
>> 18 Copyright (C) 2000 Bj??rn Jacke<bjoern at j3e.de>
> Looks like bad encoding for UTF-8 accented characters
> (\'a \'o \'e and \:o).
> Is UTF-8 allowed or should I rewrite without accents?
Sorry I do not know: Can someone else please answer this.
>> 3. usr/src/cmd/hunspell/Makefile.sfw
>> Maybe delete the commented out lines ..
>> 34 #CONFIGURE_OPTIONS += --with-ui
>
> Done. I have a question wrt this - it would be nice to be able
> to enable both the options, but both have problems.
> --with-readline
> Can be enabled, but the library is not found anyway. I'd need to
> statically link to readline present in the workspace. I've also
> noticed that each project in SFW is doing this slightly different way.
> So I'd like to ask - what's the correct path?
I again don't know, but (just a thought) ..
as readline is built in a full ws (src/lib/readline) and installed into
the ws proto area in <ws-proto>/readline-5.2/lib (but not packaged, I
assume so that the static libraries can be linked against by other
packages); you could probably extent in your Makefile.sfw the line ...
33 TARGET_ENV += "LDFLAGS=$(LDFLAGS)"
with something like ...
TARGET_ENV += LDFLAGS="$(LDFLAGS) -L $(ROOT)/readline-5.2/lib"
If that works, and is okay with the sfw team, then you might want to
consider defining something in Makefile.master for it, eg...
READLINELIB = "-L $(ROOT)/readline-5.2/lib"
so it can be used elsewhere and the version would only need changing in
one place if it was ever updated. Then in your Makefile.sfw use ..
TARGET_ENV += LDFLAGS="$(LDFLAGS) $(READLINELIB)"
> Also, it's not yet clear from OSR's point of view if this is ok
> with hunspell, so my intention was to fix this later.
>
> --with-ui
> Needs ncurses.h, but there's 6760759, so I'm turning this off for now.
> Has anyone met with this problem?
Paul
