Hi all, I'd like to ask for a secondary review of hunspell changes: http://cr.opensolaris.org/~hnhn/hunspell/
Jim Walker wrote: > Can you update the CDDL and Copyright headers to match > this. You have several variations: > http://cr.opensolaris.org/~hnhn/hunspell/usr/src/pkgdefs/Makefile.html Fixed. > What about 64 bit libraries? I included the 64b version of the lib and all headers. > usr/src/pkgdefs/SUNWhunspell/pkginfo.tmpl > - this: > 40 DESC="Hunspell spell checker" > - should be: > 40 DESC="Hunspell spell checker (1.2.8)" Fixed. Paul Cunningham wrote: > If the library is public do you also need a man page for the library; Both man3 and man4 pages are included now. > as readline is built in a full ws (src/lib/readline) and installed into > the ws proto area in <ws-proto>/readline-5.2/lib (but not packaged, I > assume so that the static libraries can be linked against by other > packages); you could probably extent in your Makefile.sfw the line ... > 33 TARGET_ENV += "LDFLAGS=$(LDFLAGS)" > with something like ... > TARGET_ENV += LDFLAGS="$(LDFLAGS) -L $(ROOT)/readline-5.2/lib" > > If that works, and is okay with the sfw team, then you might want to > consider defining something in Makefile.master for it, eg... > READLINELIB = "-L $(ROOT)/readline-5.2/lib" > so it can be used elsewhere and the version would only need changing in > one place if it was ever updated. Then in your Makefile.sfw use .. > TARGET_ENV += LDFLAGS="$(LDFLAGS) $(READLINELIB)" Hunspell is buildable with readline and ncurses if the Makefile has this: 34a35,37 > CONFIGURE_OPTIONS += --with-readline > CONFIGURE_OPTIONS += --with-ui > 37a41,43 > CPPFLAGS += -I$(ROOT)/readline-5.2/include/ -I/usr/include/ncurses/ > LDFLAGS += -L$(ROOT)/readline-5.2/lib -L/usr/gnu/lib but I'm waiting for OSR to be able to use this. I could submit the change later, along with the READLINELIB setting to Makefile.master, if that's ok. Thanks and regards, hnhn -- Jan Hnatek jan.hnatek at sun.com
