Raymond, See my comments below ...
Paul Raymond Xiong wrote: > > Please help review the code to integrate ejabberd: > > http://cr.opensolaris.org/~rayx/ejabberd_final/ > > The ARC case and discussion is at: > > https://opensolaris.org/jive/thread.jspa?messageID=243643 === Start of Comments ==== 1. usr/src/Targetdirs Move your /var/... stuff to be with the other /var stuff after line ... 1118 /var/apache2/2.2 \ (I know its all jumbled but its probably better not to make it worse :-) ) 2. usr/src/cmd/ejabberd/METADATA Add missing SRC:, SUPPORT: and BUGTRAQ: lines, see ... "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; 3. usr/src/cmd/ejabberd/Makefile.sfw & usr/src/cmd/ejabberd/install-sfw & usr/src/pkgdefs/SUNWejabberdu/Makefile & usr/src/pkgdefs/SUNWejabberdu/depend & and the others that are wrong Cosmetic: remove the double-space in the CDDL header lines so that it conforms to prototypes at .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 4. usr/src/cmd/ejabberd/Patches/configure.patch Typo in ... 1 /usr/bin/tail on Soalris doesn't support "-n" option. 5. usr/src/cmd/ejabberd/Patches/ejabberdctl.template.patch Just a thought: would it be better to patch it to 'bash' rather than 'ksh' (as that's what 'sh' would be on linux). 6. usr/src/cmd/ejabberd/install-sfw Change as follows: > Add #!/usr/bin/ksh93 at top for install-sfw* and add a > $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to catch > failures in the script and abort it at that point, > right now the script will just continue) 7. usr/src/cmd/ejabberd/sunman-stability You probably need to add SUNWejabberdr to the line .. 20 Availability SUNWejabberd and change SUNWejabberd to SUNWejabberdu 8. usr/src/common/rbac/auth_attr Might be better to try and keep this alphabetical if possible, so add your stuff higher up the list. Cosmetic: fix the top of the file so it conforms to .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; and in .. usr/src/common/rbac/exec_attr usr/src/common/rbac/prof_attr 9. usr/src/pkgdefs/SUNWejabberdr/depend Does a root package really have these dependencies? It should probably use the default depend 10. usr/src/pkgdefs/SUNWejabberdu/copyright Do you need to add the Sun disclaimer at the top? Add the source owner copyright lines, extracted from the source files in the unpacked tarball, at the topish 11. usr/src/pkgdefs/SUNWejabberdu/pkginfo.tmpl Add the pkg version number at the end of the DESC= line, eg. DESC="..... (2.0.0)" === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
