On 04/17/09, Paul Cunningham wrote: > Raymond, > > Looking good, see below for a few more comments .. > > Paul > > Raymond Xiong wrote: > >Please reload the webrev: > > http://cr.opensolaris.org/~rayx/ejabberd_final/ > > > >All your comments make sense to me (although I didn't expect > >you could find so many :), see more below... > > >>>Please help review the code to integrate ejabberd: > >>> http://cr.opensolaris.org/~rayx/ejabberd_final/ > >>> > >>>The ARC case and discussion is at: > >>> https://opensolaris.org/jive/thread.jspa?messageID=243643 > > > > >>2. usr/src/cmd/ejabberd/METADATA > You could remove the version number on the NAME: line .. > NAME: ejabberd XMPP server 2.0.0 Ok, changed.
> >>9. usr/src/pkgdefs/SUNWejabberdr/depend > It now looks like the default depend, so use that instead, > ie. remove this file and add the following instead to > SUNWejabberdr/Makefile > DATAFILES= depend I removed the duplicated depend file. Thanks! Raymond
