"URL: URL where to get current versions of the package or the package's primary website".
This is url where to get current version of unrar sources. Should I use http://www.rarlabs.com instead ? Personally I think it does not matter and will follow your recomendation :) > > 2. Typo on commit comment .. > "6691161 Mising rar archive extractor" Oh, very well spot ! > > 3. usr/src/cmd/unrar/install-unrar > Rename this to install-sfw (its more common name) done > > 4. CDDL HEADER and top of file (various files) > Cosmetic: change so that they conform to that in .. > "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; I did that. As a note, the Makefile template contains empty line at the end, nearly no other Makefile conforms to this. > > 5. usr/src/cmd/unrar/unrar.1 > Should this be in the webrev, ie. under source control ? It > looks like it came out of the tarball. Yes. I created unrar.1 and donated it to unrar author. But it is not yet in the official source release. > 6. usr/src/cmd/unrar/install-unrar > Change /bin/sh to /usr/bin/ksh93 done > > 7. usr/src/pkgdefs/SUNWunrar/copyright > Add, at top, a list of the source owner copyright > lines extracted from the unpacked src tarball Sorry, I do not understand. It's the copy of unrar's license.txt, which is in the tarball. > > 8. usr/src/pkgdefs/SUNWunrar/pkginfo.tmpl > Add the pkg version number at the end of the DESC= > line, eg ... > DESC="....... (3.8.5)" done > 9. usr/src/cmd/unrar/sunman-stability > Is the "Interface Stability Volatile" state correct? Oh, you are right. It was Volatile at first, but during PSARC it changed to Uncommitted. You have to dig into the materials to find it out :( > 10. SUNWunrar dependencies > You only have the default dependencies, is this correct? > Have you checked with the dependency checker script that > there are no others ? I checked it by ldd $ ldd /usr/bin/unrar libCstd.so.1 => /usr/lib/libCstd.so.1 libCrun.so.1 => /usr/lib/libCrun.so.1 libm.so.2 => /lib/libm.so.2 libc.so.1 => /lib/libc.so.1 Where can I find dependency checker ? Thank you -- Vlad -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 193 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090403/e3618d09/attachment.bin>
