Muktha, This mainly looks good to me :-) , but see my comment below ...
Paul Muktha Narayan wrote: > > Requesting a code review for Javamail for inclusion into SFW. JavaMail > API provides a platform-independent and protocol-independent framework > to build mail and messaging applications. > > The webrev is present at http://cr.opensolaris.org/~muktha/javamail/ === Start of Comments ==== 1. usr/src/lib/javamail/METADATA Would the following url be a better link for URL: ? ... http://java.sun.com/products/javamail/ SRC: is probably better as a link to a src tarball (bz2/gz/zip)rather than a source directory, ie. where ever you got usr/src/lib/javamail/mail-1.4.1.tar.gz from. Why are you using version 1.4.1 when there is a 1.4.2 ? (see above link). === End of comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
