Hi Paul, Paul Cunningham wrote: > This mainly looks good to me :-) , but see my comment below ... > Thanks for the review!
> === Start of Comments ==== > 1. usr/src/lib/javamail/METADATA > Would the following url be a better link for URL: ? ... > http://java.sun.com/products/javamail/ > > SRC: is probably better as a link to a src tarball > (bz2/gz/zip)rather than a source directory, ie. where > ever you got usr/src/lib/javamail/mail-1.4.1.tar.gz from. > > Why are you using version 1.4.1 when there is a 1.4.2 ? (see > above link). There is no released source tarball available for JavaMail. The mail-1.4.1.tar.gz was created after checking out the tagged (JAVAMAIL-1_4_1) JavaMail sources from cvs.dev.java.net:/cvs. So the link to the source directory has been provided. We are pulling the sources released in Glassfish community codebase ( https://glassfish.dev.java.net/javaee5/mail/) The latest version of JavaMail available in this repository is 1.4.1. Hence the same has been picked up. Regards Muktha
