Bharath, This mainly looks good to me, but see my comments below ...
Paul Bharath Kumar wrote: > Requesting a code review for activation. > > Activation (JavaBeans Activation Framework) - is a standard extension to > the Java platform that enables developers to determine the type of an > arbitrary piece of data, to encapsulate access to the data, to discover > the functional operations available on it, and to instantiate the > appropriate bean to perform the operation(s). > > Webrev: http://cr.opensolaris.org/~bkumarm/activation/ === Start of comments === 1. usr/src/lib/activation/METADATA Would the following url be a better link for URL: ? ... http://java.sun.com/javase/technologies/desktop/javabeans/jaf/ SRC: is probably better as a link to a src tarball (bz2/gz/zip)rather than a source directory, ie. where ever you got activation-1.1.1.tar.g from. 2. SUNWactivation Would the SUNW package name be better as SUNWjaf ? === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
