Hi Paul, Thanks for the review.
I have updated the webrev at http://cr.opensolaris.org/~bkumarm/activation/ Comments in-lined. Paul Cunningham wrote: >> === Start of comments === >> >> 1. usr/src/lib/activation/METADATA >> Would the following url be a better link for URL: ? ... >> http://java.sun.com/javase/technologies/desktop/javabeans/jaf/ >> SRC: is probably better as a link to a src tarball >> (bz2/gz/zip)rather than a source directory, ie. where >> ever you got activation-1.1.1.tar.g from. >> On similar lines of JavaMail, I have created activation-1.1.1.tar.g after checking out Activation sources with tag JAF-1_1_1 from cvs.dev.java.net:/cvs. Pointed to the source directory link. Again, we are pulling the sources released in Glassfish community codebase ( https://glassfish.dev.java.net/javaee5/mail/) >> 2. SUNWactivation >> Would the SUNW package name be better as SUNWjaf ? > Yeah, but I would like to keep the name SUNWactivation if that is okay with you :) > 3. depend > You are using the default 'depend', shouldn't there > be a dependency on the java pkg ? > Done, added dependency on java pkg. Thanks Bharath
