Looks good to me Norm.  Go for it.

One note for the future.  This version of ImageMagick is more than two 
years old I think.  The most recent is 6.5.1-2.  There are a great many 
additions and fixes since 6.3.4.   Might be a good idea to update it
at some point.

Steve C.

Norm Jacobs wrote:
> It was recently brought to my attention that we were delivering 64-bit 
> ImageMagick commands in /usr/bin instead of the 32-bit versions that 
> should have been there.  This is due to a problem with the Makefile.sfw 
> and the order that installation occurs.  To fix it I have done two things.
> 
>   1. added a dependency so the 32-bit install always happens after the
>      64-bit install
>   2. modified bindir for the 64-bit build so that it installs it's
>      commands into a tmp space.
> 
> These changes are very small (2 lines), and perhaps I don't really need 
> both, but they appear to resolve the issue.
> 
> The bugster bug is
>    6829259 /usr/bin/display: cannot execute binary file on AMD Athlon XP
> It was originally reported at
>    http://defect.opensolaris.org/bz/show_bug.cgi?id=8090
> 
> I would appreciate it if anyone has an opportunity to review this 
> quickly as I am going to try and make it into build 113.
> 
> Codereview is at
> 
>    http://cr.opensolaris.org/~jacobs/sfw-6829259/
> 
>    -Norm
> 
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
> 

Reply via email to