Hi Paul,

I'm sorry for the late reply



>   Re: WebRTI: RTI 331855
>
> This mainly looks okay to me, but see below ...
>
> > The url http://cr.opensolaris.org/~neuron/unrar/ is up to date all the
> > time, would you mind taking a look once you'll find the time, please ?
>
> 1. usr/src/cmd/unrar/install-sfw
>    Change line ..
>     1 #!/bin/sh
>    to use /usr/bin/ksh93
>
>    And Cosmetic: the to-of-file doesn't conform to the
>    prototypes in ..
> "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/";

done



>>> 10. SUNWunrar dependencies
>>>    You only have the default dependencies, is this correct?
>>>    Have you checked with the dependency checker script that
>>>    there are no others ?
>>
>> I checked it by ldd
>> $ ldd /usr/bin/unrar
>>         libCstd.so.1 =>  /usr/lib/libCstd.so.1
>>         libCrun.so.1 =>  /usr/lib/libCrun.so.1
>>         libm.so.2 =>     /lib/libm.so.2
>>         libc.so.1 =>     /lib/libc.so.1
>>
>> Where can I find dependency checker ?
>
> I can't remember; did you check you have all the dependencies?


Originally I did, but it didn't seem to work. I was confused by
misleading output from the script. I gave it another go, and
it found that compiler build paths were in binary RPATH and RUNPATH

$ gobjdump -x unrar/unrar | grep PATH
  RUNPATH     
/usr/lib:/ws/onnv-tools/SUNWspro/SS12/lib/rw7:/ws/onnv-tools/SUNWspro/SS12/lib:/opt/SUNWspro/lib:/usr/ccs/lib:/lib:/usr/lib
  RPATH       
/usr/lib:/ws/onnv-tools/SUNWspro/SS12/lib/rw7:/ws/onnv-tools/SUNWspro/SS12/lib:/opt/SUNWspro/lib:/usr/ccs/lib:/lib:/usr/lib

Which is wrong.

I fixed that by adding -norunpath option to CC compiler. Now both RPATH
and RUNPATH are empty (all libraries needed are in /lib and /usr/lib)

That was a good catch.


Would there be anything else I should check ?

Thank you

-- 
        Vlad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 193 bytes
Desc: not available
URL: 
<http://mail.opensolaris.org/pipermail/sfwnv-discuss/attachments/20090422/fa410a55/attachment.bin>

Reply via email to