Vlad, See my comments below from my quick skip through ...
Paul Vladimir Marek wrote: > > I would like to ask you for review of > > http://cr.opensolaris.org/~neuron/unrar/ > > It's my first, so expect unexpected :) Arc case is here: > > http://arc.opensolaris.org/caselog/PSARC/2008/756/ === Start of Comments ==== 1. usr/src/cmd/unrar/METADATA Delete the lines 1-4 (they are not needed) Is ... URL: http://www.rarlabs.com/rar_add.htm correct as the definition website for the package? It doesn't look like it to me. 2. Typo on commit comment .. "6691161 Mising rar archive extractor" 3. usr/src/cmd/unrar/install-unrar Rename this to install-sfw (its more common name) 4. CDDL HEADER and top of file (various files) Cosmetic: change so that they conform to that in .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 5. usr/src/cmd/unrar/unrar.1 Should this be in the webrev, ie. under source control ? It looks like it came out of the tarball. 6. usr/src/cmd/unrar/install-unrar Change /bin/sh to /usr/bin/ksh93 7. usr/src/pkgdefs/SUNWunrar/copyright Add, at top, a list of the source owner copyright lines extracted from the unpacked src tarball 8. usr/src/pkgdefs/SUNWunrar/pkginfo.tmpl Add the pkg version number at the end of the DESC= line, eg ... DESC="....... (3.8.5)" 9. usr/src/cmd/unrar/sunman-stability Is the "Interface Stability Volatile" state correct? 10. SUNWunrar dependencies You only have the default dependencies, is this correct? Have you checked with the dependency checker script that there are no others ? === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
