Thanks for the review Paul. I have updated the METADATA and deleted the line from depend. Do I need to resubmit the webrev? Pl. suggest.
Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Wednesday, April 22, 2009 2:55 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org; Enrique.Lopezpineda at Sun.COM; Charles.Binford at Sun.COM Subject: Re: [sfwnv-discuss] Request code review for "xsdlib" Quick skip through mainly looks good, see comments below ... paul Vivek Titarmare wrote: > I have posted a webrev for package "xsdlib" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/6816391-xsdlib/ === Start of Comments ==== 1. usr/src/lib/xsdlib/METADATA Would the following web-link be a better URL: ? ... "https://msv.dev.java.net/"; 2. usr/src/pkgdefs/SUNWxsdlib/depend Delete line ... 1 #!/usr/bin/ksh93 === End of Comments ======
