Vivek Titarmare wrote: > Thanks for the review Paul. > > I have updated the METADATA and deleted the line from depend. Do I need to > resubmit the webrev? > Pl. suggest.
it's okay with me if you don't for those two minor changes paul > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Wednesday, April 22, 2009 2:55 PM > To: Vivek Titarmare > Cc: sfwnv-discuss at opensolaris.org; Enrique.Lopezpineda at Sun.COM; > Charles.Binford at Sun.COM > Subject: Re: [sfwnv-discuss] Request code review for "xsdlib" > > Quick skip through mainly looks good, see comments below ... > > paul > > Vivek Titarmare wrote: >> I have posted a webrev for package "xsdlib" which I am porting to >> OpenSolaris and would like to request a code review. >> >> Please see below link >> http://cr.opensolaris.org/~vivekrt/6816391-xsdlib/ > > === Start of Comments ==== > > 1. usr/src/lib/xsdlib/METADATA > Would the following web-link be a better URL: ? ... > "https://msv.dev.java.net/"; > > 2. usr/src/pkgdefs/SUNWxsdlib/depend > Delete line ... > 1 #!/usr/bin/ksh93 > > === End of Comments ====== > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message
