Brian,
I'll take a proper look as this when you have resolved the other review
comments (and send out the webrev again), but here are a couple thinks
for now ....
1. usr/src/cmd/ntpd/install-sfw
Roland Mainz wrote:
> use /usr/bin/ksh93 or /usr/bin/bash for install-sfw*
> and add a $ set -o errexit # at the beginning and
> replace ". ${SRC}/tools/install.subr" with
> "source ${SRC}/tools/install.subr" (the idea is to catch
> failures in the script and abort it at that point,
> right now the script will just continue)
It doesn't look as though you are modifying the man pages
with the sunman stability stuff. And your man pages need the
line about where to get the source from
Why not use "_install <n> ....." to install the files into
the proto area (I assume the 'make install' doesn't install
everything?)
2. usr/src/cmd/ntpd/Makefile.sfw
Roland Mainz wrote:
> use either $(SHELL) or /usr/bin/bash for "configure"
> calls (so we know which one is used and "configure"
>doesn't pick one itself)
2. usr/src/pkgdefs/SUNWntpr/Makefile
You don't need the DATAFILES= line when you are supplying
you own files.
paul
Brian Utterback wrote:
> I'm upgrading NTP from the currently included version 3 to version 4,
> specifically version 4.2.5p161. There are two steps to this, since the
> packages currently reside in the ON consolidation, and afterwards they
> will reside in the SFW consolidation.
>
> I currently have the SFW webrevs available. I will have the ON webrevs
> soon. Please help to code review the modifications.
>
> The webrev is at:
> http://cr.opensolaris.org/~blu/ntpv4/sfwnv-webrev/
>
> All comments will be gratefully appreciated.
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit
