Brian, Mainly looks okay to me, but see below ....
paul Brian Utterback wrote: >> >>> http://cr.opensolaris.org/~blu/ntpv4/sfwnv-webrev/ >> >> >>>> 6. Tops of files (various files) >>>> Cosmetic: Change so that they conform to those in ... >>>> "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; >>>> >>>> >>>> as per >>>> "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; >>> >>> I am not sure what you are saying. The only files that don't have >>> CDDL and Copyright info are the Patch files. Looking at the other >>> projects in SFW, none of them have CDDL or copyright in the patch >>> files. Or am I misunderstanding you? >> >> I'm talking about the layout in the tops of your files - they are >> cosmetically different to the prototypes; and yes lots of those >> already in the sfw gate are wrong. But why propagate that wrongness. > > Do you mean the '\" t at the top of the man pages? Other than that, I > don't see any difference between the new files I introduced and the > prototypes. > > I have fixed the man pages though. okay lets take install-sfw as an example, compare .. "http://cr.opensolaris.org/~blu/ntpv4/sfwnv-webrev/usr/src/cmd/ntpd/install-sfw.html"; with "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/prototype.ksh"; and you will see there is a missing line-space after ... 20 # CDDL HEADER END 21 # (I did say it was cosmetic) - I just like new things to conform :-) and it then stops it being propagate when someone else uses your file as an example. There are other differences in other files (not all) >>>> 10. usr/src/cmd/ntpd/Solaris/ntp-keygen.1m >>>> & usr/src/cmd/ntpd/Solaris/ntpq.1m >>>> & usr/src/cmd/ntpd/Solaris/ntptime.1m >>>> & usr/src/cmd/ntpd/Solaris/ntptrace.1m >>>> And the where to find source added ? ... >>>> "Source for xxx is available on http://opensolaris.org >> its needed, I believe in the bottom of the man page also. > > Perhaps this is the same issue. It is already in all of the man pages. Found it in there; but it is normally after the 'ATTRIBUTE TYPE' stuff though, as in "http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/texinfo/sunman/sunman-stability"; >>>> 18. usr/src/cmd/ntpd/Solaris/ntprc.4 >>>> Have you delivered this in a SUNW pkg, I can't see where? >>> >>> It is a file format of an optional file, not delivered. >> >> so if its not used why not remove it - to stop confusion > > The file is used, it just isn't delivered. Somewhat similar to the > ntp.conf file, although two example files are delivered for ntp.conf. Okay if you say so :-) but I still can't see where it's used - so just out of interest please explain to me where it is used (and so can't be removed). You having mentioned ntp.conf, I can't see that this is delivered also so why is a man page, ntp.conf.4, delivered for it? If the man page is to explain how to setup up a ntp.conf file them maybe the pkg should also deliver an example ntp.conf file (I can see it doing that). Note: man-pages in the webrev form are too hard to read so I haven't. -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
