Muktha, Being as no one-else seems to have looked at this (Hint-Hint to sfwnv-discuss'ers/review requesters/Sun'ers), here are my comments from my quick skip through ...
Paul Muktha Narayan wrote: > > Requesting a code review for SAAJ for inclusion into SFW. > SAAJ provides the API for creating and sending SOAP messages by means of > the javax.xml.soap package. > > The webrev is present at http://cr.opensolaris.org/~muktha/saaj/. === Start of Comments === 1. > Please note that SAAJ depends on activation.jar which will be integrated > into SFW gate (ARC case LSARC/2009/193). Hence in order to build SAAJ, a > local copy of activation.jar is being used for the time being. SAAJ will > be integrated after activation is integrated and this local copy will be > removed and the activation.jar from the proto area will be picked up. Personally I think you should install a development version of the activation pkg on your build server rather than having your own private copy of activation.jar 2. usr/src/lib/saaj/METADATA Line ... 7 SRC: https://saaj.dev.java.net/source........ wouldn't the following be a better link ? ... "https://saaj.dev.java.net/files/documents/52/125659/saaj1.3.2.src.zip"; Why are you integrating version 1.3.2 when there is a version 1.3.3 3. usr/src/lib/saaj/install-sfw Change line 1 to /usr/bin/ksh93 4. everything else looks good to me :-) === End of Comments === -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
