Muktha, see below ...
Muktha Narayan wrote: > Paul Cunningham wrote: >> === Start of Comments === >> >> 1. >>> Please note that SAAJ depends on activation.jar which will be >>> integrated into SFW gate (ARC case LSARC/2009/193). Hence in order to >>> build SAAJ, a local copy of activation.jar is being used for the time >>> being. SAAJ will be integrated after activation is integrated and >>> this local copy will be removed and the activation.jar from the proto >>> area will be picked up. >> >> Personally I think you should install a development version >> of the activation pkg on your build server rather than having >> your own private copy of activation.jar >> > I am using a copy of activation jar that Bharath plans to integrate in > to SFW. I will remove my local copy once it gets integrated and point to > the proto area. Will not be doing a putback of SAAJ till activation gets > in. > >> 2. usr/src/lib/saaj/METADATA >> Line ... >> 7 SRC: https://saaj.dev.java.net/source........ >> wouldn't the following be a better link ? ... >> "https://saaj.dev.java.net/files/documents/52/125659/saaj1.3.2.src.zip"; >> > The zip file in the above link contains only the source java files and > does not include the docs, build.xml. Hence I have checked out > (SAAJ1.3.2 branch) sources from cvs.dev.java.net:/cvs and created > saaj-1.3.2.tar.gz file. So in the METADATA, the link to the source > directory has been provided. >> Why are you integrating version 1.3.2 when there is a version >> 1.3.3 >> > Though 1.3.3 sources are present in > https://maven-repository.dev.java.net/repository/com.sun.xml.messaging.saaj/java-sources/, > > the cvs repository from where I have checked out sources does not have > 1.3.3 branch also from the website the official stable release is still > 1.3.2. Okay, if the ARC and cteam are happy for you to check it out yourself from cvs. > Have made the above change. > The updated webrev is present at : http://cr.opensolaris.org/~muktha/saaj Looks good to me (subject to it being built and tested against the integrated 'activation' SUNW package. Paul
