Bharath, Quick skip through, see below for my comments ...
Paul Bharath Kumar wrote: > > Requesting a code review for jaxb. > > Java Architecture for XML Binding (JAXB) provides an API and tool that > allow automatic two-way mapping between XML documents and Java objects. > > Webrev: http://cr.opensolaris.org/~bkumarm/jaxb/ === Start of Comments === 1. > Please note that I am using a local copy of activation.jar now. Will > remove this once activation (LSARC/2009/193) gets integrated. > Jaxb will not be integrated till activation gets integrated. Personally I think you should install a development version of the activation pkg on your build/test server rather than having your own private copy of activation.jar 2. usr/src/lib/jaxb/METADATA This link didn't work for me ... 7 SRC: https://jaxb.dev.java.net/jaxb2-1-10-fcs/jaxb-ri-2_1_10.src.zip the following does though ... "https://jaxb.dev.java.net/2.1.10/jaxb-ri-2_1_10.src.zip"; Why are you integrating version 2.1.10 when there is version 2.1.11 ? 3. usr/src/lib/jaxb/install-sfw Change line 1 to use /usr/bin/ksh93 4. usr/src/lib/jaxb/jaxb.3 Lines .. 42 For more details in jaxb jars please see, https://jaxb.dev.java.net/nonav/2.1.10/docs/ReleaseNotes.html 46 For more details on using the tools please see, https://jaxb.dev.java.net/nonav/2.1.10/docs should you be delivering this as part of the package rather than pointing user at a web-link that may disappear? 5. usr/src/pkgdefs/SUNWjaxb/pkginfo.tmpl Cosmetic: Delete line 1 Version number on DESC= line is wrong 6. man pages Should there be man pages for 'jaxb-xjc' and jaxb-schemagen' that delivered in /usr/bin ? (they might just be a man page link to the jaxb.3 page). === End of Comments === -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
