Bharath,
Looks good to me. Just a couple of other things/questions ...
1. usr/src/lib/jaxb/install-sfw
You could indent line 82 ...
79 for i in ${JAXB_JARS}
80 do
81
82 _install N ${JAXBDIR}/lib/${i} ${JARDIR}/${i} 444
83
84 done
Question: The jar file jsr173_1.0_api.jar, is the 1.0 some
sort of version number ? Does this jar file get built from
scratch and if so why is it 1.0 rather than 2.1.11 ? If it
is not built from scratch are you allowed to install it?
Also, what is the 173 number ?
Paul
Bharath Kumar wrote:
> Hi Paul,
>
> Thanks for the review, have done the changes that you have suggested.
>
> The updated webrev is at http://cr.opensolaris.org/~bkumarm/jaxb/
>
> Please see replies inline.
>
> Paul Cunningham wrote:
>>
>> Bharath Kumar wrote:
>>
>>> Please note that I am using a local copy of activation.jar now. Will
>>> remove this once activation (LSARC/2009/193) gets integrated.
>>> Jaxb will not be integrated till activation gets integrated.
>>
>> Personally I think you should install a development version
>> of the activation pkg on your build/test server rather than
>> having your own private copy of activation.jar
>
> The activation.jar that I am using is the same that I will be
> integrating to SFW gate. Will be removing the local copy and will point
> to proto area before integrating JAXB.
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit
