Hi David,
Few review comments:
1. cmd/Makefile
The entries should be in alphabetical order.
2. As per the website, areca 7.1 has been released, is there a specific
reason why 7.0.8 is being integrated?
3. Makefile.sfw
a) 'pragma ident' keyword is generally not used in files other than
source files. In Makefiles, install scripts and such, use "ident"
(without "pragma").
b) You can avoid hard-coding program name and version and instead
extract this info from METADATA, something like:
VER = $(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh)
4. install-areca
a) The install files are usually named as install-sfw.
b) The dirs created by 'mkdir -p' should be in the Targetdirs file
so you don't have to create it here.
c) Please check if the files installed (icons, translations) need to
have 555 permission.
5. depend
a) Please check if there are any missing dependencies by running the
check-deps.pl script or by doing "make check_deps" in
usr/src/pkgdefs/SUNWareca dir.
b) If there are no project specific dependency then the default
depend file can be used by including the below line in SUNWareca/Makefile
DATAFILES = depend
6. pkginfo.tmp
a) You could add the pkg version number at the end of the DESC.
DESC="Areca- backup utilities (7.0.8)"
7. prototype_com
a) Please check the permission on the directories it should be 0755.
b) Please check if pngs and *.properties files need 0555 permission.
Regards
Muktha
David Zhang wrote:
> Hi experts,
>
> Would you please kindly review those webrev for opensolaris package
> SUNWareca?
> http://cr.opensolaris.org/~ydzhang/areca/
>
> Regards,
> David
>
>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
