David, See below ...
paul David Zhang wrote: > > Thank you for your comments, I have addressed it and update a new > webrev. Would you please take a look again, highly appreciate. > http://cr.opensolaris.org/~ydzhang/areca/ >>> >>>>> David Zhang wrote: >>>>>> Would you please kindly review those webrev for opensolaris package >>>>>> SUNWareca? >>>>>> http://cr.opensolaris.org/~ydzhang/areca/ 1. usr/src/Targetdirs Add these alphabetically, ie. after /usr/share/antlr-2.7.7 >>> 3. usr/src/cmd/areca/install-sfw >>> >>> Do you need the lines 'i=""' ? if not remove them. I still don't see why you need these lines ? >>> >>> 4. usr/src/pkgdefs/SUNWareca/Makefile >>> You have your own 'depend' file so delete line .. >>> 30 DATAFILES = depend See item (7) ... >>> 7. usr/src/pkgdefs/SUNWareca/depend >>> You deliver some 'jar' files in prototype_com so shouldn't >>> there be a dependency on the java runtime package? I still thing you have another dependency here! Also have you run the dependency checker script on your pkg? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
