Dipesh, This mainly looks good to me, couple of minor comments below ...
paul Dipesh Hadye wrote: > I have posted a webrev for package "stringtemplate" which I am porting > to OpenSolaris and would like to request a code review. > Please see below link > http://cr.opensolaris.org/~vivekrt/6816372-Stringtemplate/ 1. usr/src/lib/stringtemplate/METADATA The OWNER: should probably be you 2. usr/src/lib/stringtemplate/sunman/stringtemplate.3 Should the multi-space-char gap be there on line 34 ? END
