Hi Paul,

Done the following changes:

>1. usr/src/lib/stringtemplate/METADATA
        Changed the owner. 
        OWNER:          Dipesh.Hadye at Sun.COM

>2. usr/src/lib/stringtemplate/sunman/stringtemplate.3
        Removed the unnecessary multi-space-char gap in the file.

Thanks & Regards,
Dipesh Hadye

        
-----Original Message-----
From: Paul Cunningham [mailto:[email protected]] 
Sent: Monday, April 27, 2009 6:32 PM
To: Dipesh Hadye
Cc: sfwnv-discuss at opensolaris.org
Subject: Re: [sfwnv-discuss] Request code review for "stringtemplate"

Dipesh,

This mainly looks good to me, couple of minor comments below ...

paul

Dipesh Hadye wrote:
>  I have posted a webrev for package "stringtemplate" which I am porting 
> to OpenSolaris and would like to request a code review.
>  Please see below link
> http://cr.opensolaris.org/~vivekrt/6816372-Stringtemplate/


1. usr/src/lib/stringtemplate/METADATA
    The OWNER:  should probably be you

2. usr/src/lib/stringtemplate/sunman/stringtemplate.3
    Should the multi-space-char gap be there on line 34 ?

END


Reply via email to