Dipesh, See comments below ...
Paul Dipesh Hadye wrote: > I have posted a webrev for package "antlr" which I am porting to > OpenSolaris and would like to request a code review. > Please see below link > http://cr.opensolaris.org/~vivekrt/6816371-antlr/ 1. usr/src/lib/antlr/METADATA Change OWNER: to you Just checking: on the BUGTRAQ: line, is 'java-classes' correct? 2. usr/src/lib/antlr/install-sfw Cosmetic: change top-of-file so it conforms to that in .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; Copyright year is wrong. Line ... 27 VER=3.0 is not used so remove Add a '$ set -o errexit' after header, as in ... "http://cr.opensolaris.org/~vivekrt/6816372-Stringtemplate/usr/src/lib/stringtemplate/install-sfw.html"; 3. usr/src/lib/antlr/sunman/antlr.3 Line .. 41 /usr/share/lib/java/antlr.jar -> antlr-3.0.jar (sym link) do you need to refer to antlr-3.0.jar? You will have to change this for every source version update if you do. Line ... 69 .B file:/usr/share/lib/java/javadoc/antlr277/index.html why the reference to this old version. 4. usr/src/pkgdefs/SUNWantlr/pkginfo.tmpl Cosmetic: Line .. 34 NAME="antlr - (AN)other (T)ool for (L)anguage (R)ecognition" it might be nicer to leave of the brackets () on the NAME line END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
