Hi Jim, thanks a lot for your review.
> Add a METADATA file for ant. Here's an example: Done > Cleanup the CDDL and copyright headers What files are incorrect? "wx pbchk" says everyting is OK > rename install-ant to install-sfw a lot of packages in source tree folllow "install-productName" template(apache, bash, bind, bzip, etc) so prefer to stay with "-ant" suffix. > rename ant.1.sunman to sunman-stability, > and move it up to /src/cmd/ant, and > remove sunman directory, and update > install-sfw accordingly. Done > - do you still need to target the obsolete > /usr/sfw/* directories? No interface changes planned for this update so I need to keep this obsolete stuff. There is updated webrev at opensolaris.org: http://cr.opensolaris.org/~jinb/ant/ Is it look better? Thanks a lot. With best regards, Evgeny Jim Walker wrote: > Evgeny Bessonov wrote: > >> Hello, >> >> I'm working on update of apache ant to latest stable release (1.7.1) >> And here is webrev for proposed update: >> http://cr.opensolaris.org/~jinb/ant/ > > > Here's a few things to get it in more consistent shape: > > Add a METADATA file for ant. Here's an example: > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/meld/METADATA > > Cleanup the CDDL and copyright headers in all the files. Here's > an example: > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/meld/Makefile.sfw > > rename install-ant to install-sfw and update Makefile.sfw > accordingly. > > rename ant.1.sunman to sunman-stability, > and move it up to /src/cmd/ant, and > remove sunman directory, and update > install-sfw accordingly. > > usr/src/cmd/ant/install-ant > usr/src/pkgdefs/SUNWant/prototype_com > - do you still need to target the obsolete > /usr/sfw/* directories? > > Cheers, > Jim >
