Hi Jim, > usr/src/cmd/ant/METADATA > 1 NAME: Apache Ant is a Java-based build tool > - remove this line
Is "Package writing guidelines"-> "Definition of METADATA fields" chapter incorrect? http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines thanks Evgeny Jim Walker wrote: > Evgeny Bessonov wrote: > >> Hi Jim, >> >> thanks a lot for your review. >> >> > Add a METADATA file for ant. Here's an example: > > > usr/src/cmd/ant/METADATA > 1 NAME: Apache Ant is a Java-based build tool > - remove this line > 2 PROGRAM: Ant > - change "Ant" to "ant" > >> > Cleanup the CDDL and copyright headers >> What files are incorrect? > > > All files are incorrect. The headers need to match exactly. Here's > an example. Please update all the files in the /usr/ant and > pkgdefs/SUNWant/ > directories not just the ones in the webrev. > http://src.opensolaris.org/source/xref/sfw/usr/src/cmd/meld/Makefile.sfw > >> > rename install-ant to install-sfw >> a lot of packages in source tree folllow >> "install-productName" template(apache, bash, bind, bzip, etc) >> so prefer to stay with "-ant" suffix. > > > Sorry. There are alot of bad examples :( > That's an old standard. Please change it. > > Cheers, > Jim >
