Muktha Narayan wrote: > Hi Daria, > > I have incorporated the review comments. == cut == > Yes, konkret has only compile-time dependency on Pegasus. Hence was > using the default 'depend' file in the Makefile. > Also, in usr/src/cmd/Makefile, 'konkretcmpi' entry has been put after > 'cimserver' (Pegasus) entry. Please let know if an explicit entry > 'konkretcmpi: cimserver' is required at the end of the Makefile.
If the dependency is just on the headers, I don't think that's necessary. > > Please review the changes. > webrev: http://cr.opensolaris.org/~muktha/konkretcmpi/ Looks good to me, except I think the manpage needs to include the line about source availability, like that added by sunman-stability: .SH NOTES Source for konkretcmpi is available on http://opensolaris.org. Best, -- daria
