Hi Paul, Daria, I have incorporated the changes suggested by you in Makefile.sfw, install-sfw[-64] and have included the sunman-stability section and NOTES section in the konkret.1 and konkretreg.1 manpages itself. Please review the modified webrev: http://cr.opensolaris.org/~muktha/konkretcmpi/
Regards Muktha Paul Cunningham wrote: > Muktha, > > This mainly looks okay to me, but here are a few more comments for > you, see below ... > > Paul > > Muktha Narayan wrote: > ... cut ... >> >> Please review the changes. >> webrev: http://cr.opensolaris.org/~muktha/konkretcmpi/ > > === Start of Comments ==== > > 1. usr/src/cmd/konkretcmpi/Makefile.sfw > Change the 'clean:' rule so that the two 'rm' are done > together. eg. > clean: > -rm -rf $(VER) $(VER64) > > I don't think you really need the 'real-all:', just change > all: real-all > to > all: all32 all64 > > 2. usr/src/cmd/konkretcmpi/install-sfw-64 > Add the 'set -o errexit' as per konkretcmpi/install-sfw > > 3. usr/src/cmd/konkretcmpi/install-sfw > Cosmetic: add line space after the '#ident' line > > 4. usr/src/cmd/konkretcmpi/*.1 > Don't you need to add the sun stability stuff to these > man pages, either directly in the file or using the > sunman-stability modification via '_install M ...' in your > install-sfw script. > > === End of Comments ======
