On Fri, 2008-07-04 at 18:54, Prashant Srinivasan wrote: > Cunningham, Paul - UK wrote: > > Looks okay to me. > > Does the pkginfo.tmpl have a version number on its DESC= line, if so > > does that need the p230 bit appended? > > > > Thanks, it did, and that's fixed now, as well as a few files that I had > not listed in prototype_* that nightly told me about. > I have a clean nightly now, except for 2 lines about cups(which, iirc > can be ignored?). > > http://cr.opensolaris.org/~psriniva/webrev-6721879-v4/ >
SUNWruby18r/pkginfo.tmpl & SUNWruby18u/pkginfo.tmpl The 'VERSION= line doesn't look right to me, shouldn't it be 'VERSION="SFWVERS,REV=0.0.0"' You need to change the 'Copyright' year. prototype_i386.tmpl & prototype_i386.tmpl I just noticed - why are these prototype files .tmpl ? I don't think that is the normal way of doing it Paul > -ps > > > > Paul > > > > > >> -----Original Message----- > >> From: sfwnv-discuss-bounces at opensolaris.org > >> [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of > >> Prashant Srinivasan > >> Sent: 03 July 2008 22:35 > >> To: sfwnv-discuss at opensolaris.org > >> Subject: [sfwnv-discuss] Code review for Ruby patch update(CR 6721879) > >> > >> [setting Reply-to to webstack-discuss] > >> > >> Can someone review this patch from the upstream community? > >> It updates Ruby to 1.8.6-p230. Importantly it houses a fix > >> for a reported Security vulnerability. > >> > >> http://cr.opensolaris.org/~psriniva/webrev-6721879-v2/ > >> > >> Thanks, > >> -ps > >> > >> > >> > >> > >> -- > >> Prashant Srinivasan > >> F/OSS Enthusiast > >> Sun Microsystems, Inc. > >> http://blogs.sun.com/prashant > >> GnuPG key: > >> http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A > >> > >> _______________________________________________ > >> sfwnv-discuss mailing list > >> sfwnv-discuss at opensolaris.org > >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss > >> > >> > > _______________________________________________ > > > > > > webstack-discuss mailing list > > webstack-discuss at opensolaris.org > > http://mail.opensolaris.org/mailman/listinfo/webstack-discuss > > > > > -- > Prashant Srinivasan > F/OSS Enthusiast > Sun Microsystems, Inc. > http://blogs.sun.com/prashant > GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A >
