Hi Paul. Paul Cunningham wrote: > > SUNWruby18r/pkginfo.tmpl & SUNWruby18u/pkginfo.tmpl > The 'VERSION= line doesn't look right to me, shouldn't it be > 'VERSION="SFWVERS,REV=0.0.0"' > You need to change the 'Copyright' year. >
I think that this was what was used in the original integration, but no-one picked up on it then. Will discuss with Prashant and fix. > prototype_i386.tmpl & prototype_i386.tmpl > I just noticed - why are these prototype files .tmpl ? I don't think > that is the normal way of doing it > It's not, if I remember correctly binutils was used as a template and that's the way it was done there. The Makefile creates the correct files depending on the Machine type. Again it's something I'll discuss with Prashant. I think that we should take all of the great advice you provide along with any other "common mistakes" and create an FAQ. Thanks Amanda > Paul > > >> -ps >> >> >> >>> Paul >>> >>> >>> >>>> -----Original Message----- >>>> From: sfwnv-discuss-bounces at opensolaris.org >>>> [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of >>>> Prashant Srinivasan >>>> Sent: 03 July 2008 22:35 >>>> To: sfwnv-discuss at opensolaris.org >>>> Subject: [sfwnv-discuss] Code review for Ruby patch update(CR 6721879) >>>> >>>> [setting Reply-to to webstack-discuss] >>>> >>>> Can someone review this patch from the upstream community? >>>> It updates Ruby to 1.8.6-p230. Importantly it houses a fix >>>> for a reported Security vulnerability. >>>> >>>> http://cr.opensolaris.org/~psriniva/webrev-6721879-v2/ >>>> >>>> Thanks, >>>> -ps >>>> >>>> >>>> >>>> >>>> -- >>>> Prashant Srinivasan >>>> F/OSS Enthusiast >>>> Sun Microsystems, Inc. >>>> http://blogs.sun.com/prashant >>>> GnuPG key: >>>> http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A >>>> >>>> _______________________________________________ >>>> sfwnv-discuss mailing list >>>> sfwnv-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >>>> >>>> >>>> >>> _______________________________________________ >>> >>> >>> webstack-discuss mailing list >>> webstack-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/webstack-discuss >>> >>> >> -- >> Prashant Srinivasan >> F/OSS Enthusiast >> Sun Microsystems, Inc. >> http://blogs.sun.com/prashant >> GnuPG key: http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x82FBDE5A >> >> > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss > -- Amanda Waite ISV-Engineering OSS, Sun Microsystems Tel: +44 (0)1252 420693 Mobile: +44 (0)7802 175732
