Daniel Templeton wrote: > All, > > Please see the review page at: > > http://cr.opensolaris.org/~templedf/fftw/ > > I made *no changes* to the FFTW source, Makefiles, or configuration > files. All of the porting effort was in providing the wrapping > framework for the OpenSolaris SFW consolidation. FFTW itself remains > wholy unchanged. > > Please send review comments to dan.templeton at sun.com. Please also send > lack of review comments, i.e. you looked at it and it looks fine. > > Thank you! > Daniel > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss > ==== Start of comments ===== 1. It looks like your workspace is not updated. try wx update
2. llib-lfftw copyright date says 2007 should this be 2008? 3. llib-lfftw3 copyright date says 2007 should this be 2008? 4. pkgdefs/SUNWfftw2/Makefile copyright date should be 2008. 5. pkgdefs/SUNWfftw2/depend copyright date should be 2008. 6. pkgdefs/SUNWfftw2/pkginfo.tmpl copyright date should be 2008. 7. pkgdefs/SUNWfftw3/Makefile copyright date 8. pkgdefs/SUNWfftw3/depend copyright date 9. pkgdefs/SUNWfftw3/pkginfo.tmpl copyright date This is only my first go at reviewing. So you may wish to have someone with more experience look also. ====== End of comments =======
