usr/src/Targetdirs
you appear to be changing several unrelated things here (libxml,
libxslt, snack, openexr, zsh, wxwidgets). It looks like it's
conflict resolution related.
usr/src/lib/Makefile
same as above, it looks like you have conflict resolution issues.
usr/src/lib/fftw2/METADATA
can you add PACKAGES, SUPPORT, BUGTRAQ and URL information.
usr/src/lib/fftw2/Makefile.sfw
You appear to be adding several compiler flags for optimization.
Some of these flags should be inherited from the upper level
Makefiles and the others should be documented in your Makefile.
usr/src/lib/fftw3/install-sfw*
cherry picking files from .../.libs/ for installation doesn't always
give you the desired.
You might consider using "make install" to install your bits
directly in the proto area
(cd $(VER) ; env INSTALL=$(INSTALL_PROTO) DESTDIR=$(ROOT) ...
make install)
and fix what you need to or install in a tmpdir and cherry pick from
there. Anyway, I would at least audit the binaries and libraries
that you are cherry picking to make sure that they are linked the
way you want them.
usr/src/lib/fftw3/*
similar comments to the fftw2 files
usr/src/pkgdefs/Makefile
looks like you have conflict resolution problems.
usr/src/pkgdefs/SUNWfftw2/depend
You appear to be using the standard depend file. Your Makefile
includes the DATAFILES line to retrieve it. If you are, this should
not be under SCCS control, but generated by your build instead.
usr/src/pkgdefs/SUNWfftw2/pkginfo
This should not be under SCCS control, it should be generated by
your build.
usr/src/pkgdefs/SUNWfftw2/prototype_com
check the permissions of your files.
usr/src/pkgdefs/SUNWfftw3/*
same as for SUNWfftw2 files
-Norm
Daniel Templeton wrote:
> Thank you for the excellent review comments, everyone. Since the
> comments prompted several fairly pervasive changes, I've posted a new
> webrev here:
>
> http://cr.opensolaris.org/~templedf/fftw2/
>
> As before, let me know if there are (or aren't) comments.
>
> Thanks,
> Daniel
>
> Bruce Rothermal wrote:
>
>> Daniel Templeton wrote:
>>
>>> All,
>>>
>>> Please see the review page at:
>>>
>>> http://cr.opensolaris.org/~templedf/fftw/
>>>
>>> I made *no changes* to the FFTW source, Makefiles, or configuration
>>> files. All of the porting effort was in providing the wrapping
>>> framework for the OpenSolaris SFW consolidation. FFTW itself remains
>>> wholy unchanged.
>>>
>>> Please send review comments to dan.templeton at sun.com. Please also
>>> send lack of review comments, i.e. you looked at it and it looks fine.
>>>
>>> Thank you!
>>> Daniel
>>> _______________________________________________
>>> sfwnv-discuss mailing list
>>> sfwnv-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>>>
>>>
>> ==== Start of comments =====
>> 1. It looks like your workspace is not updated.
>> try wx update
>>
>> 2. llib-lfftw copyright date says 2007 should this be 2008?
>>
>> 3. llib-lfftw3 copyright date says 2007 should this be 2008?
>>
>> 4. pkgdefs/SUNWfftw2/Makefile copyright date should be 2008.
>>
>> 5. pkgdefs/SUNWfftw2/depend copyright date should be 2008.
>>
>> 6. pkgdefs/SUNWfftw2/pkginfo.tmpl copyright date should be 2008.
>>
>> 7. pkgdefs/SUNWfftw3/Makefile copyright date
>>
>> 8. pkgdefs/SUNWfftw3/depend copyright date
>>
>> 9. pkgdefs/SUNWfftw3/pkginfo.tmpl copyright date
>>
>> This is only my first go at reviewing. So you may wish to have someone
>> with more experience look also.
>>
>> ====== End of comments =======
>>
>>
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
>
