John, See below for my comments ...
Paul John Gu wrote: > > I am working on package porting of libsigsegv, which is a library > for handling page faults in user mode. > Please kindly help review it. > > The link is: http://cr.opensolaris.org/~john.gu/libsigsegv/ === Start of Comments === 1. usr/src/Targetdirs & usr/src/pkgdefs/Makefile It looks as though you need to resync this with the sfw gate, so it doesn't look as though you are trying to delete stuff. Please in future do a self review of your webrev before sending it out!! 2. usr/src/lib/libsigsegv/METADATA Add missing fields, see ... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 3. usr/src/lib/libsigsegv/Makefile.sfw You could extract the 'VER=' stuff from the METADATA info, see recent sfw integrations on how to do that. 4. usr/src/lib/libsigsegv/install-sfw & usr/src/lib/libsigsegv/install-sfw-64 You could pass in the 'VERS=' stuff in from Makefile.sfw as a environment variable. The dir created by 'mkdir -p' should be in the Targetdirs file so you don't have to create it here. 5. *.3 man page files Were these man page files extracted from the src tarball? If they were why are you not installing them from there? I haven't looked at any of these. 6. usr/src/pkgdefs/SUNWlibsigsegv/depend This looks like the default 'depend' file! have you checked your pkg has no other dependencies (with the pkg dependency checker script): if not delete this file and add 'DATAFILES = depend' to your SUNWlibsigsegv/Makefile. If it has, then add them here, and also ... move the 'Copyright' lines to after the 'CDDL HEADER END' header. 7. usr/src/pkgdefs/SUNWlibsigsegv/pkginfo.tmpl Add version the end of the DESC= line, eg. DESC="........ (2.6)" 8. usr/src/pkgdefs/SUNWlibsigsegv/prototype_i386 & usr/src/pkgdefs/SUNWlibsigsegv/prototype_sparc & usr/src/pkgdefs/SUNWlibsigsegv/prototype_com Just for clarity, it might be better if the 'symbolic link' (s) lines come after the 'file' (f) lines. === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
