John Gu wrote: > Thanks for your fast feeback, Paul. > Please see my comments below.
... cut ... >>> Please kindly help review it. >>> >>> The link is: http://cr.opensolaris.org/~john.gu/libsigsegv/ ... cut .. >> 3. usr/src/lib/libsigsegv/Makefile.sfw >> You could extract the 'VER=' stuff from the METADATA >> info, see recent sfw integrations on how to do that. > Could you please tell me the instruction link? I didn't find it. See the following as an example ... http://cr.opensolaris.org/~jwalker/meld/usr/src/cmd/meld/Makefile.sfw.html .... cut .. >> 5. *.3 man page files >> Were these man page files extracted from the src tarball? >> If they were why are you not installing them from there? >> >> I haven't looked at any of these. > The src tarball doesn't cover any man pages. These files are newly created. > What's the right way to handle the library man pages? I'm no expert, but I think what you have done looks okay to me for newly created files. Some people though do put the sunman-stability stuff directly into file. But what you have done is fine by me, especially if you are going to give them back to the opensource community (are you?) Paul -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
