Darren J Moffat wrote: > Anup Sekhar wrote: >> On Dec 5, 2008, at 6:41 AM, Jim Walker wrote: >> >>> Huie-Ying Lee wrote: >>>>> *usr/src/lib/pyopenssl/pyOpenSSL.txt >>>>> - where did this file come from? >>>>> >>>> The pyOpenSSL.txt was downloaded from http://pyopenssl.sourceforge.net. >>>>> - it appears to be from: >>>>> pyOpenSSL-0.8/doc/pyOpenSSL.tex >>>>> - pyOpenSSL.txt should be removed and >>>>> generated during the build. It needs to be insync >>>>> with the current tarball. >>>>> >>>>> >>>> I tried to generate it from the doc directory extracted from the >>>> tarball, but failed to do that, because there is no "latex" command >>>> on Solaris. >>>> I asked some co-workers and nobody know about it. >>>> Do you know if the "latex" command is available on Solaris ? >>> Maybe you need to port latex too. It sounds like you are >>> dependent on it. > > The code isn't the docs just happen to be in tex format. > >> What does all this have to do with "code review?" Porting LaTeX is out >> of the scope for this project. We are trying to do the right thing here >> by trying to integrate a highly useful FOSS piece into OpenSolaris. >> Piling on requirements like these are only going to delay or stop the >> project altogether. Are you sure that's what want? > > I'm 100% with Anup here. There is no chance what so ever that this > group will port latex just beause the pyOpenSSL docs are in tex format. > > If the SFW C-Team requires this I will go as high up the management > chain as I need to to get it overruled. It might sound like I'm being > arrogant and heavy handed and yes I am pyOpenSSL is far too important to > many GNOME desktop apps that are important to OpenSolaris and it is used > by IPS. > > LaTeX/TeX is a HUGE bit of software that is highly complex - yes I'd > love to see it in the IPS repo but requiring it as part of pyOpenSSL and > worse yet using it as part of an SFW build is insanity. >
I don't make the rules, and I am done with this review. (I need a break from doing code reviews anyway :) The cteam can take it from here. Huie-Ying, Thanks for addressing the other issues. I have no other comments. Good job! Cheers, Jim
