Charles, This mainly looks okay to me now, just a few more minor comments ...
Paul zheng he - Sun Microsystems - Beijing China wrote: > I have made the corresponding > modification. Would you like to take a look on it again. > > Webrev: http://cr.opensolaris.org/~zhenghe/clisp/ 1. usr/src/pkgdefs/SUNWclisp/depend Delete the 'Copyright' lines at the top of the file (lines 1 to 3), as it's also below the CDDL header 2. usr/src/cmd/clisp/install-sfw You could pass in the VERS= info from the Makefile.sfw as an environment variable maybe. 3. usr/src/Targetdirs Try and keep it in alphabetical order, ie. move /usr/clisp up to before /usr/demo -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
