Hi Jim, I've prepared the materials for ARC review, could you kindly help me with review process.
Proposal: http://cr.opensolaris.org/~zhenghe/arc/proposal.txt Man Page: http://cr.opensolaris.org/~zhenghe/arc/clisp.1.txt Thanks! -Charles He zheng he - Sun Microsystems - Beijing China ??: > Hi Jim, > > I 've updated my webrev per your comments at: > > http://cr.opensolaris.org/~zhenghe/clisp/ > <http://cr.opensolaris.org/%7Exiang/iftop/> > > > Could you please take another look at it. > > Thanks > > -Charles He > > > Jim Walker ??: >> zheng he - Sun Microsystems - Beijing China wrote: >>> >>> Hi Paul, >>> >>> I have updated the files per your comments. Should I move into next >>> step "ARC Review" now. >> >> I can help you with the ARC review when you have the materials ready. >> >>> http://cr.opensolaris.org/~zhenghe/clisp/ >> >> I didn't review your code, but why are you >> organizing clisp by version directories? >> >> This is normally done only when you need to support >> two or more component versions at the same time. >> >> Do you need to support multiple versions of clisp? >> >> If not, you can use this much simpler layout: >> >> /usr/bin/clisp >> /usr/lib/clisp/... >> /usr/share/clisp/... >> /usr/share/doc/clisp/... >> >> Cheers, >> Jim > >
