Xiang, See my comments below from my quick skip through ...
Paul Xiang Zhou wrote: > > I am working on package porting of iftop, which is a tool for displaying > bandwidth usage on network interfaces. Please kindly help review it. The > webrev link is: > > http://cr.opensolaris.org/~xiang/iftop/ === Start of Comments === 1. usr/src/cmd/iftop/METADATA Make the NAME: line more descriptive 2. usr/src/cmd/iftop/install-sfw You could pass in VERS= from the Makefile.sfw as an environment variable, ie. in .. Makefile.sfw something like ... PKGVERS=$(VER) $(SHELL) ./install-sfw install-sfw something like ... PKGVERS=${PKGVERS} Then there is .. Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* and > add a '$ set -o errexit' at the beginning 3. usr/src/pkgdefs/SUNWiftop/depend Move the 'Copyright' lines to after the 'CDDL HEADER END' header 4. usr/src/pkgdefs/SUNWiftop/pkginfo.tmpl Add version at end of DESC= line, eg .. DESC="........ (0.17)" 5. usr/src/pkgdefs/SUNWiftop/prototype_com Remove the write permission on files installed in /usr (its okay in install-sfw). === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
