Paul and Alan, Thank you very much for the comments. I've updated the webrev according to your advice at:
http://cr.opensolaris.org/~xiang/iftop/ On 12/10/08 23:36, Alan Coopersmith wrote: > This package shouldn't be installing links to the unrelated libncurses. > If you want those links, file a bug to get the ncurses package to install > them, and either wait for that to integrate, or use the correct -L & -R > flags to find it in /usr/gnu/lib until then. > > -Alan Coopersmith- alan.coopersmith at sun.com > Sun Microsystems, Inc. - X Window System Engineering > Make sense. From my updated webrev, I used "configure LDFLAGS=\"-L/usr/gnu/lib -R/usr/gnu/lib\"" for configuration in Makefile.sfw, so that iftop can find libncurse.so* when it is running. On 12/11/08 16:08, Paul Cunningham wrote: > Xiang, > > See my comments below from my quick skip through ... > > Paul > === Start of Comments === > > 1. usr/src/cmd/iftop/METADATA > Make the NAME: line more descriptive > > 2. usr/src/cmd/iftop/install-sfw > You could pass in VERS= from the Makefile.sfw as an > environment variable, ie. in .. > Makefile.sfw something like ... > PKGVERS=$(VER) $(SHELL) ./install-sfw > install-sfw something like ... > PKGVERS=${PKGVERS} > > Then there is .. > Roland Mainz wrote: > > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* and > > add a '$ set -o errexit' at the beginning > > 3. usr/src/pkgdefs/SUNWiftop/depend > Move the 'Copyright' lines to after the > 'CDDL HEADER END' header > > 4. usr/src/pkgdefs/SUNWiftop/pkginfo.tmpl > Add version at end of DESC= line, eg .. > DESC="........ (0.17)" > > 5. usr/src/pkgdefs/SUNWiftop/prototype_com > Remove the write permission on files installed > in /usr (its okay in install-sfw). > > === End of Comments ===== Welcome to give comments ! -- Best Regards, Xiang
